Azure: Remove AKS vmType #6133
Azure: Remove AKS vmType #6133
Conversation
k8s-ci-robot
added
kind/deprecation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/provider/azure
k8s-ci-robot
added
area/cluster-autoscaler
size/XL
|
we plan on not removing this at the moment |
Signed-off-by: Jack Francis <[email protected]>
jackfrancis
force-pushed
the
azure-provider-deprecate-aks
branch
from
4a833e9 to
cdef63c
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Closing per comment from @gandhipr above. Please reopen if anything changes. /close |
|
@x13n: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I don't have permissions for reopening a PR. Feel free to reopen if you have permissions to do so @jackfrancis . |
|
/reopen (this probably won't work from me :)) |
|
@jackfrancis: Failed to re-open PR: state cannot be changed. The azure-provider-deprecate-aks branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
lol I'll open a new PR |
|
/reopen |
|
@gandhipr: Failed to re-open PR: state cannot be changed. The azure-provider-deprecate-aks branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Huh, looks like nobody can reopen if there were changes to the source branch. I see there's a new PR now, apologies for the trouble! |
|
@x13n No prob, TIL (well earlier this week to be exact 😀) |
What type of PR is this?
/kind deprecation
/kind documentation
/kind cleanup
What this PR does / why we need it:
This PR removes the obsolete, non-working implementation for manual AKS cluster integration as expressed via the
"aks"vmTypeconfiguration.Node autoscaling has long been a first class GA feature of AKS. See:
Running the Azure cluster-autoscaler provider manually on your cluster is not a supported feature. To aid future maintainability of the project, we're removing these non-working code paths and updating documentation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: